Remove reference to msg in debugging statements to enable compilation#21
Open
proan wants to merge 1 commit intoodriverobotics:masterfrom
Open
Remove reference to msg in debugging statements to enable compilation#21proan wants to merge 1 commit intoodriverobotics:masterfrom
msg in debugging statements to enable compilation#21proan wants to merge 1 commit intoodriverobotics:masterfrom
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the process of debugging my code to handle the library changes from 0.10.6 to 0.10.9, I enabled the
DEBUGmacro in ODriveCAN.h L7. This caused compilation errors in Arduino IDE thatmsgis not defined. This PR fixes the compiler error and allows debugging output to be printed to the serial port.I did not address the logic errors in https://github.com/proan/ODriveArduino/blob/4ea624266ac28df369194129cfced0f840966c72/src/ODriveCAN.cpp#L221 -- https://github.com/proan/ODriveArduino/blob/4ea624266ac28df369194129cfced0f840966c72/src/ODriveCAN.cpp#L224, but I would be happy to do so with some additional guidance on desired behavior.