Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
CHANGELOG
=========

4.2.0
4.2.0 (2026-02-26)
------------------

* Added `trackingToken` to the `Device` request object. This is the token
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ To do this, add the dependency to your pom.xml:
<dependency>
<groupId>com.maxmind.minfraud</groupId>
<artifactId>minfraud</artifactId>
<version>4.1.0</version>
<version>4.2.0</version>
</dependency>
```

Expand All @@ -29,7 +29,7 @@ repositories {
mavenCentral()
}
dependencies {
implementation 'com.maxmind.minfraud:minfraud:4.1.0'
implementation 'com.maxmind.minfraud:minfraud:4.2.0'
}
```

Expand Down
14 changes: 7 additions & 7 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

<groupId>com.maxmind.minfraud</groupId>
<artifactId>minfraud</artifactId>
<version>4.1.0</version>
<version>4.2.0</version>
<name>MaxMind minFraud API</name>
<description>MaxMind minFraud Score, Insights, Factors and Report Transaction API</description>
<url>http://dev.maxmind.com/minfraud</url>
Expand Down Expand Up @@ -53,12 +53,12 @@
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-core</artifactId>
<version>2.21.0</version>
<version>2.21.1</version>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
<version>2.21.0</version>
<version>2.21.1</version>
Comment on lines +56 to +61

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To ensure all Jackson dependencies are kept on the same version and to simplify future updates, consider defining the Jackson version as a property in the <properties> section. This property can then be used for all Jackson artifacts.

For example, in <properties>:

<jackson.version>2.21.1</jackson.version>

And in the <dependencies> section:

<dependency>
    <groupId>com.fasterxml.jackson.core</groupId>
    <artifactId>jackson-core</artifactId>
    <version>${jackson.version}</version>
</dependency>
<dependency>
    <groupId>com.fasterxml.jackson.core</groupId>
    <artifactId>jackson-databind</artifactId>
    <version>${jackson.version}</version>
</dependency>

Adopting this approach would prevent potential version mismatches between related Jackson artifacts (like jackson-annotations which appears to be on a different version) and make maintenance easier.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is what it says about jackson-annotations correct? It looks like it is on 2.21.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is misleading. jackson-annotations does not have patch releases, probably because it just contains annotations and any change would be a breaking change (but I don't actually know the reasoning).

</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
Expand All @@ -68,7 +68,7 @@
<dependency>
<groupId>com.fasterxml.jackson.datatype</groupId>
<artifactId>jackson-datatype-jsr310</artifactId>
<version>2.21.0</version>
<version>2.21.1</version>
</dependency>
<dependency>
<groupId>com.maxmind.geoip2</groupId>
Expand Down Expand Up @@ -96,7 +96,7 @@
<dependency>
<groupId>com.fasterxml.jackson.jr</groupId>
<artifactId>jackson-jr-objects</artifactId>
<version>2.21.0</version>
<version>2.21.1</version>
<scope>test</scope>
</dependency>
<dependency>
Expand All @@ -121,7 +121,7 @@
<configuration>
<rules>
<requireMavenVersion>
<version>3.6.3</version>
<version>3.8.1</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, it seems there are newer versions than this still?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just sets the minimum version that the user must use. I use 3.9.11, for instance. I think requiring the latest version would make building/releasing more painful.

I updated it because it was complaining that a plugin needed a newer version than the minimum specified.

I don't know exactly why we are specifying a version ourselves. I didn't dig into the history.

</requireMavenVersion>
</rules>
</configuration>
Expand Down Expand Up @@ -263,7 +263,7 @@
<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<!-- Baseline version for API compatibility checking. Update after each release. -->
<japicmp.baselineVersion>4.1.0</japicmp.baselineVersion>
<japicmp.baselineVersion>4.2.0</japicmp.baselineVersion>
</properties>

<profiles>
Expand Down
Loading