-
Notifications
You must be signed in to change notification settings - Fork 8
Release 4.2.0 #605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 4.2.0 #605
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,7 +4,7 @@ | |
|
|
||
| <groupId>com.maxmind.minfraud</groupId> | ||
| <artifactId>minfraud</artifactId> | ||
| <version>4.1.0</version> | ||
| <version>4.2.0</version> | ||
| <name>MaxMind minFraud API</name> | ||
| <description>MaxMind minFraud Score, Insights, Factors and Report Transaction API</description> | ||
| <url>http://dev.maxmind.com/minfraud</url> | ||
|
|
@@ -53,12 +53,12 @@ | |
| <dependency> | ||
| <groupId>com.fasterxml.jackson.core</groupId> | ||
| <artifactId>jackson-core</artifactId> | ||
| <version>2.21.0</version> | ||
| <version>2.21.1</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>com.fasterxml.jackson.core</groupId> | ||
| <artifactId>jackson-databind</artifactId> | ||
| <version>2.21.0</version> | ||
| <version>2.21.1</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>com.fasterxml.jackson.core</groupId> | ||
|
|
@@ -68,7 +68,7 @@ | |
| <dependency> | ||
| <groupId>com.fasterxml.jackson.datatype</groupId> | ||
| <artifactId>jackson-datatype-jsr310</artifactId> | ||
| <version>2.21.0</version> | ||
| <version>2.21.1</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>com.maxmind.geoip2</groupId> | ||
|
|
@@ -96,7 +96,7 @@ | |
| <dependency> | ||
| <groupId>com.fasterxml.jackson.jr</groupId> | ||
| <artifactId>jackson-jr-objects</artifactId> | ||
| <version>2.21.0</version> | ||
| <version>2.21.1</version> | ||
| <scope>test</scope> | ||
| </dependency> | ||
| <dependency> | ||
|
|
@@ -121,7 +121,7 @@ | |
| <configuration> | ||
| <rules> | ||
| <requireMavenVersion> | ||
| <version>3.6.3</version> | ||
| <version>3.8.1</version> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmm, it seems there are newer versions than this still?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This just sets the minimum version that the user must use. I use 3.9.11, for instance. I think requiring the latest version would make building/releasing more painful. I updated it because it was complaining that a plugin needed a newer version than the minimum specified. I don't know exactly why we are specifying a version ourselves. I didn't dig into the history. |
||
| </requireMavenVersion> | ||
| </rules> | ||
| </configuration> | ||
|
|
@@ -263,7 +263,7 @@ | |
| <properties> | ||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
| <!-- Baseline version for API compatibility checking. Update after each release. --> | ||
| <japicmp.baselineVersion>4.1.0</japicmp.baselineVersion> | ||
| <japicmp.baselineVersion>4.2.0</japicmp.baselineVersion> | ||
| </properties> | ||
|
|
||
| <profiles> | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To ensure all Jackson dependencies are kept on the same version and to simplify future updates, consider defining the Jackson version as a property in the
<properties>section. This property can then be used for all Jackson artifacts.For example, in
<properties>:And in the
<dependencies>section:Adopting this approach would prevent potential version mismatches between related Jackson artifacts (like
jackson-annotationswhich appears to be on a different version) and make maintenance easier.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is what it says about jackson-annotations correct? It looks like it is on
2.21.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is misleading.
jackson-annotationsdoes not have patch releases, probably because it just contains annotations and any change would be a breaking change (but I don't actually know the reasoning).