Conversation
oschwald
commented
Feb 26, 2026
oschwald
commented
- Update Jackson deps to 2.21.1
- Prepare for 4.2.0 release
- Fix maven version warning
- Preparing for 4.2.0
Summary of ChangesHello @oschwald, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on preparing for the 4.2.0 release. It includes essential version updates across project configuration files and documentation, alongside an upgrade of core Jackson dependencies to their latest patch version. Additionally, the build environment's minimum Maven requirement has been adjusted to ensure compatibility and address potential warnings. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request prepares for the 4.2.0 release by updating version numbers and dependencies. The changes are mostly straightforward. I've added one suggestion to improve dependency management in pom.xml to ensure version consistency across related artifacts and improve maintainability.
| <version>2.21.1</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>com.fasterxml.jackson.core</groupId> | ||
| <artifactId>jackson-databind</artifactId> | ||
| <version>2.21.0</version> | ||
| <version>2.21.1</version> |
There was a problem hiding this comment.
To ensure all Jackson dependencies are kept on the same version and to simplify future updates, consider defining the Jackson version as a property in the <properties> section. This property can then be used for all Jackson artifacts.
For example, in <properties>:
<jackson.version>2.21.1</jackson.version>And in the <dependencies> section:
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-core</artifactId>
<version>${jackson.version}</version>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
<version>${jackson.version}</version>
</dependency>Adopting this approach would prevent potential version mismatches between related Jackson artifacts (like jackson-annotations which appears to be on a different version) and make maintenance easier.
There was a problem hiding this comment.
Is what it says about jackson-annotations correct? It looks like it is on 2.21.
There was a problem hiding this comment.
It is misleading. jackson-annotations does not have patch releases, probably because it just contains annotations and any change would be a breaking change (but I don't actually know the reasoning).
| <version>2.21.1</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>com.fasterxml.jackson.core</groupId> | ||
| <artifactId>jackson-databind</artifactId> | ||
| <version>2.21.0</version> | ||
| <version>2.21.1</version> |
There was a problem hiding this comment.
Is what it says about jackson-annotations correct? It looks like it is on 2.21.
| <rules> | ||
| <requireMavenVersion> | ||
| <version>3.6.3</version> | ||
| <version>3.8.1</version> |
There was a problem hiding this comment.
Hmm, it seems there are newer versions than this still?
There was a problem hiding this comment.
This just sets the minimum version that the user must use. I use 3.9.11, for instance. I think requiring the latest version would make building/releasing more painful.
I updated it because it was complaining that a plugin needed a newer version than the minimum specified.
I don't know exactly why we are specifying a version ourselves. I didn't dig into the history.
2 participants
