Skip HTTP proxy in base class for TCP-only extensions#130
Merged
Conversation
whummer
changed the title
whummer
force-pushed
the
fix/tcp-only-base-class
branch
from
0c1a0d2 to
902c003
Compare
purcell
reviewed
Feb 27, 2026
purcell
approved these changes
Feb 27, 2026
Contributor
purcell
left a comment
purcell
left a comment
There was a problem hiding this comment.
Left a small suggestion, but otherwise it looks reasonable to me!
Add Lambda resource matching in the proxy handler (FunctionName/ARN-based) and comprehensive integration tests covering basic proxying, read-only mode, and resource name pattern matching. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
When all container ports are TCP-only and no host restriction is set, the base class now skips setting up the catch-all HTTP proxy that would intercept all requests. This moves the logic from ParadeDB's override into ProxiedDockerContainerExtension directly. Also temporarily rewrites localstack-extensions-utils dependencies to git+https for CI testing of the utils change across all extensions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The utils package imports from localstack at runtime (docker.py), so it must be a runtime dependency, not just a dev/test extra. Without this, installing utils via git ref in CI fails with ModuleNotFoundError. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Moving localstack to runtime deps broke the utils CI venv setup. Revert to keeping it in dev/test extras where it was before — the paradedb CI issue is unrelated to this. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
localstack 4.14.0 no longer depends on localstack-core, making it a thin CLI wrapper. The framework code (localstack.config, localstack.utils etc.) now requires localstack-core explicitly. Update all dev/test dependencies accordingly. Also add WireMock extension to the extensions table in the root README. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
PostgreSQL may not be ready to accept queries immediately after the TCP port becomes reachable (Docker port forwarding opens the port before PostgreSQL finishes initialization). Retry the connection to handle this timing window. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: Steve Purcell <steve@sanityinc.com>
whummer
force-pushed
the
fix/tcp-only-base-class
branch
from
c94ee6e to
2d9d625
Compare
whummer
force-pushed
the
fix/tcp-only-base-class
branch
from
4eff2bb to
8605b94
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip HTTP proxy in base class for TCP-only extensions. This PR addresses a TODO that was added as a temporary workaround for the ParadeDB extension in a previous PR.