Update to allow sourcing docker images from internal registry#129
Update to allow sourcing docker images from internal registry#129
Conversation
…, by adding prefix to image name - leverages existing DOCKER_GLOBAL_IMAGE_PREFIX config
…o allow usage when latest tag is blocked
plafond
changed the title
…tate - also updated minor version trying to ensure changes get applied
whummer
left a comment
whummer
left a comment
There was a problem hiding this comment.
Great catch, kudos for fixing that @plafond . 🚀 Added a small comment around the pro import guards.
not sure if minor bump on the extension-utils package is actually needed?
The patch version bump to 0.1.1 of utils should be fine - I'll release a new version post merge. 👍
| self.image_name = image_name | ||
| from localstack.constants import ENV_PRO_ACTIVATED | ||
|
|
||
| pro_activated = is_env_true(ENV_PRO_ACTIVATED) |
There was a problem hiding this comment.
Rather than checking the environment variable here, I think it would be better to add a try/except around the import (this will decouple us a bit more from the env variable, and leave the logic of gated code imports to higher abstraction levels 👍 ).
Update: briefly chatted with Pat about this offline, we'll merge this as-is for now, and then look into further CI coverage of this feature under different plans (free plan, enterprise plan, etc) post image consolidation launch.
Also, build errors in CI are unrelated to this branch - will fix those separately as part of #130 👍
2 participants
Leverages existing DOCKER_GLOBAL_IMAGE_PREFIX config, if present, by adding prefix to image name.
Customer request created for wiremock extension but this change is to a common util and should apply to ALL extensions...
** also looking ahead, adding ability to wiremock extension to specify image name (including tag) to allow usage when latest tag is blocked
wiremock/wiremock:4x-beta image seems to have issues (getting a connection refused) - specifying :latest is working fine
not sure if minor bump on the extension-utils package is actually needed?