add footer navigation and breadcrumbs#29
Open
ritorhymes wants to merge 2 commits intogitgitgadget:mainfrom
Open
add footer navigation and breadcrumbs#29ritorhymes wants to merge 2 commits intogitgitgadget:mainfrom
ritorhymes wants to merge 2 commits intogitgitgadget:mainfrom
Conversation
The architecture and reply-to-this pages were orphaned with no way to navigate to or between them. Add a simple footer with horizontal flexbox links to provide basic site navigation. Also normalize unquoted `href`/`src` attributes before parsing generated HTML in `graphviz-ssr.js`. This prevents `node-html-parser` from rewriting links like `href=../architecture/` into empty anchors during SSR.
Add schema.org BreadcrumbList markup to help search engines understand the site hierarchy. The home page gets a single breadcrumb; sub-pages get Home plus the current page title.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WARNING: This PR is dependent on PR #28 as it requires (1) prettyURLs and (2) baseURL to function properly which that PR adds. DO NOT MERGE WITHOUT THOSE LIVE FIRST
Summary
graphviz-ssr.jsfrom rewriting footer URLs into empty links.Demo site: https://gitgitgadget.ritovision.com