Skip to content

Update Runegraft of Refraction and add Fury parsing#9509

Open
EtherealCarnivore wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
EtherealCarnivore:runegraft-fury-refraction
Open

Update Runegraft of Refraction and add Fury parsing#9509
EtherealCarnivore wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
EtherealCarnivore:runegraft-fury-refraction

Conversation

@EtherealCarnivore
Copy link

Description of the problem being solved:

Runegraft of Refraction was changed in 3.28 from "Skills Chain +1 times" to "Projectiles Chain +1 times". Updated the display text and added a parser entry for the new projectile-specific wording.

Also added parsing for Runegraft of Fury's "Gain 3 Rage when you use a Life Flask" so the rage config shows up when it's allocated.

Steps taken to verify a working solution:

  • Full test suite passes (195/0/0/0)
  • Parser entries follow existing patterns for projectile chain and rage gain mods
  • ModCache entries match the format of neighboring entries

Link to a build that showcases this PR:

N/A — Runegraft tree data for these hasn't been exported yet, but the parsing is ready for when it is.

Refraction changed from "Skills Chain" to "Projectiles Chain" in 3.28.
Fury grants rage on life flask use.
@majochem
Copy link
Contributor

majochem commented Mar 2, 2026

FYI src/Data/TattooPassives.lua is actually auto-generated by the export scripts (says so at the top of the file, but I've overlooked it in the past myself 🙃 ).

You'd have to check if there are changes necessary within src/Export/Scripts/tattooPassives.lua instead. (but I think it should work without changes in this case, once the game files are updated)

@EtherealCarnivore
Copy link
Author

Ah yep, missed that comment at the top. You're right that the export should pick up the new wording from the game data on its own. I can revert that file if you want to keep the diff clean - the ModParser and ModCache bits are the actual functional changes anyway.

@EtherealCarnivore
Copy link
Author

Spoke with LocalIdentity - two changes based on his feedback:

  1. Fury rage mod now uses HaveLifeFlask condition instead of just CanGainRage alone. HaveLifeFlask is set in CalcPerform:1579 when a life flask is socketed in the build (even if disabled), vs UsingLifeFlask which only fires when the flask is active. This way the rage config only shows up if you actually have a life flask.

  2. Dropped the TattooPassives.lua edit - that file is auto-generated by the export scripts, so it'll pick up the new wording on its own when the game data is exported for league release.

The ModParser + ModCache changes for both Refraction ("Projectiles Chain +1 times") and Fury ("Gain 3 Rage when you use a Life Flask") are on the runegraft-fixes branch. Full test suite passes (195/0/0/0).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants