Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR rewrites the ChaCha20Poly1305 wrapper to use a one-shot (non-streaming) AEAD interface aligned with the existing AesSiv pattern.
Changes:
- Replaced the streaming-style API with one-shot
encrypt(aad, iv, plaintext)anddecrypt(aad, iv, authTag, ciphertext). - Enforced RFC 7539 key size by restricting
_key_sizesto 32 bytes. - Updated and expanded tests for the new interface, including invalid key-size and bad-tag cases.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| wolfcrypt/ciphers.py | Replaces streaming state with one-shot calls to the underlying wolfCrypt ChaCha20-Poly1305 functions. |
| tests/test_chacha20poly1305.py | Updates tests to use the new API and adds negative tests for key size and tag verification. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Made
wolfcrypt/ciphers.py — ChaCha20Poly1305 class rewritten
Removed (streaming-style interface):
New interface (matches AesSiv pattern):
tests/test_chacha20poly1305.py — updated tests
Fixes #83