fix: Normalize urls in precompile-schemas#32
Open
batchu5 wants to merge 1 commit intowebpack:mainfrom
Open
Conversation
|
|
| logger: false, | ||
| loadSchema: (uri) => { | ||
| schemaPath = fileURLToPath(uri); | ||
| schemaPath = fileURLToPath(new URL(decodeURI(uri))); |
Member
There was a problem hiding this comment.
Can you provide me value of uri on windows?
Author
There was a problem hiding this comment.
file:///C%253A/Users/varsh/Desktop/webpack/schemas/WebpackOptions.json
Member
There was a problem hiding this comment.
Weird, looks like ajv is doing something extra, but should not
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests are failing in the webpack repository on Windows because
URL normalizationis not occurring.What kind of change does this PR introduce?
fix: normalize the
URLin precompile-schemesDid you add tests for your changes?
no
Does this PR introduce a breaking change?
no
discussion on Discord -> https://discord.com/channels/1180618526436888586/1180619658307571843/1475119754061811936