feat(ecmascript): Temporal.PlainTime constructor#965
Open
jesperkha wants to merge 3 commits intotrynova:mainfrom
Open
feat(ecmascript): Temporal.PlainTime constructor#965jesperkha wants to merge 3 commits intotrynova:mainfrom
jesperkha wants to merge 3 commits intotrynova:mainfrom
Conversation
Add create_temporal_plain_time
aapoalas
reviewed
Mar 3, 2026
| let h = if hours.get(agent).is_undefined() { | ||
| Ok(0) | ||
| } else { | ||
| u8::try_from( |
Member
There was a problem hiding this comment.
issue: Let's end all of the try_from's with an unwrap_or(u8/u16::MAX), and replace Ok(0)s with just 0.
aapoalas
reviewed
Mar 3, 2026
|
|
||
| // 8. If IsValidTime(hour, minute, second, millisecond, microsecond, nanosecond) is false, throw a RangeError exception. | ||
| // 9. Let time be CreateTimeRecord(hour, minute, second, millisecond, microsecond, nanosecond). | ||
| let time = if let ( |
Member
There was a problem hiding this comment.
note: Here splitting into the else branch becomes unnecessary after adding unwrap_or(...) to each of the above else-branches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.