Add static from method to Response class for flexible response creation.#50
Merged
gustavofreze merged 1 commit intomainfrom Feb 24, 2026
Merged
Add static from method to Response class for flexible response creation.#50gustavofreze merged 1 commit intomainfrom
gustavofreze merged 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds a generic from method to the Response class that allows creating HTTP responses with any status code, providing more flexibility than the existing status-specific methods (ok, created, accepted, etc.). The new method serves as a factory method for creating responses with custom status codes while maintaining the same API as the specialized methods.
Changes:
- Added a static
frommethod to theResponsesinterface andResponseclass that accepts anyCodeenum value - Implemented comprehensive test coverage using a data provider pattern to test multiple status codes and body types
- Maintained consistency with existing API design by delegating to
InternalResponse::createWithBody
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Responses.php | Added interface definition for the from method with proper documentation |
| src/Response.php | Implemented the from method delegating to InternalResponse::createWithBody |
| tests/ResponseTest.php | Added comprehensive test coverage using data provider pattern with 5 test cases covering various status codes and body types |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.