Fix potential race with the sliding window sample. (Closes #279)#280
Open
billrich2001 wants to merge 1 commit intomainfrom
Open
Fix potential race with the sliding window sample. (Closes #279)#280billrich2001 wants to merge 1 commit intomainfrom
billrich2001 wants to merge 1 commit intomainfrom
Conversation
billrich2001
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Switch position of adding record.id to the current_records to before starting the child WF to avoid race.
Why?
If child WF completes before the record.id is added, its signal will be sent and ignored because the ID was not in the list
Checklist