Address bug where aws v4 signatures get their service/region swapped in creds.#43
Draft
Address bug where aws v4 signatures get their service/region swapped in creds.#43
Conversation
…in creds. There's a bug in the aws v4 processor. It reads the existing signature and then updates it with a new signature. It extracts the region and service fields from the old signature in the wrong order, so when it generates a new signature, they are swapped to service then region. Unfortunately we have active use cases that depend on this behavior. So this commit introduces an optional fix, with the default behavior being to preserve the field swapping bug behavior. - Add new flag to the processor "no_swap", defaulting to false. When not present or fault the existing swapping behavior is preserved. When it is true, the fields are not swapped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a bug in the aws v4 processor. It reads the existing signature and then updates it with a new signature. It extracts the region and service fields from the old signature in the wrong order, so when it generates a new signature, they are swapped to service then region. Unfortunately we have active use cases that depend on this behavior. So this commit introduces an optional fix, with the default behavior being to preserve the field swapping bug behavior.