ROX-33133: Remove hardcoded key-exchange in gRPC#2991
ROX-33133: Remove hardcoded key-exchange in gRPC#2991vladbologa wants to merge 2 commits intomasterfrom
Conversation
cbcea86 to
7544bea
Compare
There was a problem hiding this comment.
I'm a bit concerned about carrying a patch for this ourselves. I can already tell the line has moved on the master branch of grpc, so when we decide to update the dependency, this patch will need to be regenerated.
Is there any way we could directly upstream something instead of working around it ourselves?
There was a problem hiding this comment.
I'm just trying to get ML-KEM to work for now.
As for the upstreaming, I don't know. They had a ticket and they didn't fix it. It would be best to fix it upstream, but I'm not sure that can be done in time for 4.11.
cc9fab5 to
10a9dc5
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2991 +/- ##
=======================================
Coverage 27.38% 27.38%
=======================================
Files 95 95
Lines 5427 5427
Branches 2548 2548
=======================================
Hits 1486 1486
Misses 3214 3214
Partials 727 727
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/retest collector-on-push |
Description
A detailed explanation of the changes in your PR.
Feel free to remove this section if it is overkill for your PR, and the title of your PR is sufficiently descriptive.
Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why you did not do so. (Valid reasons include "CI is sufficient" or "No testable changes")
In addition to reviewing your code, reviewers must also review your testing instructions, and make sure they are sufficient.
For more details, ref the Confluence page about this section.