ROX-31149: Improve monitoring deployment customization#83
Open
JoukoVirtanen wants to merge 4 commits intomainfrom
Open
ROX-31149: Improve monitoring deployment customization#83JoukoVirtanen wants to merge 4 commits intomainfrom
JoukoVirtanen wants to merge 4 commits intomainfrom
Conversation
9 tasks
tommartensen
requested changes
Feb 26, 2026
Collaborator
tommartensen
left a comment
tommartensen
left a comment
There was a problem hiding this comment.
The approach works, but I have a concern about the general structure of the scripts in the start-secured-cluster directory.
| # Replace the prometheus ConfigMap with one that doesn't scrape as much info from berserker containers | ||
| kubectl -n stackrox delete configmap prometheus | ||
| kubectl create -f "${SCRIPT_DIR}"/prometheus.yaml | ||
| # Compare version to determine which script to use |
Collaborator
There was a problem hiding this comment.
Why do we have two different versions, what is the difference between them? I would prefer to have just start-secured-cluster.sh and if necessary control logic and functions for each version there.
That should reduce code duplication and make the intents clearer.
Contributor
Author
There was a problem hiding this comment.
I have combined the scripts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently monitoring for the long running clusters the config for the Prometheus is overwritten. This was done in a PR for increasing the berserker load. That change required changes to the Prometheus config. A comment in that PR suggested another method for adjusting the Prometheus config for the long running cluster. This PR implements that suggestion.
See the companion stackrox/stackrox PR stackrox/stackrox#18928
Testing is explained there.