fix(executor): prevent raw workflowInput from overwriting coerced start block values

[waleedlatif1]

Summary

• Prevent buildUnifiedStartOutput and buildIntegrationTriggerOutput from overwriting schema-coerced structuredInput values with raw workflowInput strings
• Add structuredKeys guard so the workflowInput loop skips keys already set by coerceValue, preserving typed values (arrays, objects, numbers, booleans) passed to child workflows

Type of Change

• Bug fix

Testing

• bun run --filter sim test -- executor/utils/start-block.test.ts (11 tests pass)
• New tests: coerced type preservation (number, object, boolean), structured key priority over duplicated workflowInput keys, EXTERNAL_TRIGGER path

Checklist

• Code follows project style guidelines
• Self-reviewed my changes
• Tests added/updated and passing
• No new warnings introduced
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Fixes #3105

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Feb 26, 2026 3:51am

[greptile-apps]

Greptile Summary

This PR fixes a bug where raw workflowInput string values would overwrite schema-coerced typed values (numbers, objects, booleans) set by coerceValue in the start block output builders.

• Adds a structuredKeys guard in both buildUnifiedStartOutput and buildIntegrationTriggerOutput that skips workflowInput keys already present in structuredInput, preserving typed values produced by coerceValue
• Keys not in the schema are still passed through from workflowInput, maintaining backward compatibility
• Adds 3 well-structured test cases covering type preservation for the UNIFIED and EXTERNAL_TRIGGER paths, including a priority test with duplicated keys

Confidence Score: 5/5

• This PR is safe to merge — it's a minimal, well-tested bug fix with no risk of regressions.
• The change is small (6 lines of logic added), surgically targeted, and preserves backward compatibility for keys not in the input schema. The fix is applied consistently to both affected functions. Three new tests directly validate the fix, and the overall test suite passes.
• No files require special attention.

Important Files Changed

Filename	Overview
apps/sim/executor/utils/start-block.ts	Adds structuredKeys guard in buildUnifiedStartOutput and buildIntegrationTriggerOutput to prevent raw workflowInput strings from overwriting schema-coerced typed values. Clean, minimal fix.
apps/sim/executor/utils/start-block.test.ts	Adds 3 new test cases covering coerced type preservation (number, object, boolean) for both UNIFIED and EXTERNAL_TRIGGER paths, including priority over duplicated workflowInput keys.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[buildStartBlockOutput] --> B[deriveInputFromFormat]
    B --> C{hasStructured?}
    C -->|Yes| D[coerceValue per field → structuredInput]
    C -->|No| E[Pass raw workflowInput through]
    D --> F[buildUnifiedStartOutput / buildIntegrationTriggerOutput]
    F --> G[Copy structuredInput to output]
    G --> H{workflowInput key in structuredKeys?}
    H -->|Yes - NEW GUARD| I[Skip — preserve coerced value]
    H -->|No| J[Merge workflowInput value into output]
    I --> K[Return output]
    J --> K

Loading

_{Last reviewed commit: b3687a8}

[greptile-apps]

_{4 files reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

Additional Comments (1)

apps/sim/executor/utils/start-block.ts
Same overwrite issue exists here

buildIntegrationTriggerOutput has the same pattern that was fixed in buildUnifiedStartOutput — it writes schema-coerced structuredInput keys first (line 393-394), then iterates workflowInput and unconditionally overwrites them (line 400-401) when the raw value is non-null. Consider applying the same structuredKeys guard here for consistency:

  if (isPlainObject(workflowInput)) {
    const structuredKeys = hasStructured ? new Set(Object.keys(structuredInput)) : null
    for (const [key, value] of Object.entries(workflowInput)) {
      if (structuredKeys?.has(key)) continue
      if (value !== undefined && value !== null) {
        output[key] = value
      } else if (!Object.hasOwn(output, key)) {
        output[key] = value
      }
    }
  }

[waleedlatif1]

@greptile

[waleedlatif1]

@cursor review

[cursor]

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

[waleedlatif1]

@cursor review

[waleedlatif1]

@greptile

[cursor]

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR