Skip to content

Comments

improvement(creds): bulk paste functionality, save notification, error notif#3328

Merged
waleedlatif1 merged 5 commits intostagingfrom
fix/creds-ui
Feb 25, 2026
Merged

improvement(creds): bulk paste functionality, save notification, error notif#3328
waleedlatif1 merged 5 commits intostagingfrom
fix/creds-ui

Conversation

@waleedlatif1
Copy link
Collaborator

Summary

bulk paste functionality, save notification, error notifs

Type of Change

  • Bug fix
  • New feature

Testing

Tested manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link

vercel bot commented Feb 25, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview, Comment Feb 25, 2026 3:11am

Request Review

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 25, 2026

Greptile Summary

This PR enhances the credentials management UI with bulk paste functionality for environment variables, unsaved changes detection, and consistent error notifications using Badge components.

Key changes:

  • Bulk paste: Pasting env-style text now auto-populates fields (single entry) or switches to bulk mode (multiple entries)
  • Unsaved changes protection: Added modal close interception when credential details have unsaved edits
  • UI improvements: Replaced custom error/warning alerts with Badge components across the app for consistency
  • Better UX: Improved OAuth reconnect button labels, repositioned form elements, and added LastPass ignore attributes

The implementation correctly handles the paste functionality by parsing env text and conditionally switching between single and bulk input modes. The unsaved changes flow uses Zustand store state to coordinate between the credentials manager and settings modal.

Confidence Score: 4/5

  • This PR is safe to merge with one minor performance consideration to address.
  • The changes are well-structured and implement the stated features correctly. One useEffect dependency issue could cause unnecessary re-renders but won't break functionality. The bulk paste logic is sound, and the unsaved changes flow properly prevents data loss.
  • credentials-manager.tsx has a minor useEffect optimization opportunity (see inline comment)

Important Files Changed

Filename Overview
apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/settings-modal/components/credentials/credentials-manager.tsx Added bulk paste, unsaved changes handling, improved UI with Badge components, and better OAuth flow. Minor useEffect callback dependency issue.
apps/sim/stores/modals/settings/store.ts Added state management for unsaved changes tracking with clean store actions.
apps/sim/stores/modals/settings/types.ts Added type definitions for unsaved changes state and callback handler.
apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/settings-modal/settings-modal.tsx Integrated unsaved changes detection to intercept modal close attempts.

Last reviewed commit: 0688ee9

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

@waleedlatif1 waleedlatif1 merged commit ecdb133 into staging Feb 25, 2026
6 checks passed
@waleedlatif1 waleedlatif1 deleted the fix/creds-ui branch February 25, 2026 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant