Skip to content

Resolve some issues added by recents merges#1210

Merged
fjtirado merged 1 commit intoserverlessworkflow:mainfrom
fjtirado:rearrange_dependencies
Mar 6, 2026
Merged

Resolve some issues added by recents merges#1210
fjtirado merged 1 commit intoserverlessworkflow:mainfrom
fjtirado:rearrange_dependencies

Conversation

@fjtirado
Copy link
Collaborator

@fjtirado fjtirado commented Mar 6, 2026

No description provided.

Copilot AI review requested due to automatic review settings March 6, 2026 16:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR cleans up issues introduced by recent merges by adjusting test module dependencies, fixing numeric conversion in the experimental Java-backed model, and correcting package declarations for lambda executor tests.

Changes:

  • Remove experimental test dependencies from impl/test Maven module.
  • Update JavaModel numeric conversion logic for various Number target types.
  • Fix package declarations in two experimental lambda test classes to match their directory/package structure.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
impl/test/pom.xml Removes experimental test-scoped dependencies from the impl test module.
experimental/model/src/main/java/io/serverlessworkflow/impl/model/func/JavaModel.java Refactors asNumber(Class<N>) conversion behavior for numeric targets.
experimental/lambda/src/test/java/io/serverless/workflow/impl/executors/func/WorkflowThenTest.java Corrects the test class package declaration to match its path/module.
experimental/lambda/src/test/java/io/serverless/workflow/impl/executors/func/WorkflowNumberConversionTest.java Corrects the test class package declaration to match its path/module.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@fjtirado fjtirado force-pushed the rearrange_dependencies branch from 3c7d4cd to a869fc7 Compare March 6, 2026 16:42
Signed-off-by: fjtirado <ftirados@redhat.com>
@fjtirado fjtirado force-pushed the rearrange_dependencies branch from a869fc7 to e4be3b8 Compare March 6, 2026 16:49
@fjtirado fjtirado merged commit aab1365 into serverlessworkflow:main Mar 6, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants