Open
Conversation
Add the `STORAGE_PROVIDER` environment variable for running revng tests with pypeline.
Use the `--export-dynamic` option as it fixes the same issue as `--shared` but it's less invasive and does not break debug info in binaries.
aleclearmind
reviewed
Mar 4, 2026
Comment on lines
+361
to
+369
| function cleanup() { | ||
| if [ -n "${_MSPDBSRV_ENDPOINT_:-}" ]; then | ||
| # Stop mspdbsrv.exe upon exit | ||
| wine "$SCRIPT_DIR"/(@= bin @)/mspdbsrv.ex*e -stop || true | ||
| fi | ||
| wineserver --kill || true | ||
| rm -rf "$WINEPREFIX" | ||
| } | ||
| trap cleanup EXIT |
Contributor
There was a problem hiding this comment.
The whole mspdbsrv business can disappear: having distinct WINEPREFIXes ensures that MSVC does not reuse mspdbserver, ever. They're like distinct "containers".
You can drop the _MSPDBSRV_ENDPOINT_ business, the wait, all of it.
Use a separate WINEPREFIX for each invocation of `cl.exe` to avoid any race conditions with it.
mrjackv
force-pushed
the
feature/pypeline-port-tests
branch
from
e86fd6d to
751f93b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.