Update CLAUDE.md with project guidance#2358
Merged
alexeyzimarev merged 2 commits intodevfrom Feb 26, 2026
Merged
Conversation
Replace minimal MCP server note with full developer guidance including build/test commands, architecture overview, code conventions, and multi-targeting notes. Uses .slnx solution format with a note about net8.0 incompatibility requiring project-level test runs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Review Summary by QodoAdd comprehensive developer guidance to CLAUDE.md
WalkthroughsDescription• Replace minimal MCP note with comprehensive developer guidance • Document build, test, and pack commands using .slnx format • Add detailed architecture overview and core class descriptions • Include multi-targeting strategy, code conventions, and testing stack Diagramflowchart LR
A["Minimal CLAUDE.md<br/>MCP note only"] -->|Replace with| B["Comprehensive CLAUDE.md"]
B --> C["Build & Test<br/>Commands"]
B --> D["Project Overview<br/>& Architecture"]
B --> E["Code Conventions<br/>& Testing Stack"]
C --> F["dotnet build/test<br/>with .slnx"]
D --> G["Core classes &<br/>Request pipeline"]
E --> H["Multi-targeting &<br/>Code style"]
File Changes1. CLAUDE.md
|
Contributor
Code Review by Qodo
1.
|
Deploying restsharp with
|
| Latest commit: |
a57c1ec
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4c3e0e17.restsharp.pages.dev |
| Branch Preview URL: | https://update-claude-md.restsharp.pages.dev |
![qodo-free-for-open-source-projects[bot]](https://avatars.githubusercontent.com/in/1068000?s=60&v=4){kind=small}
Comment on lines
+11
to
+24
| # Run all tests | ||
| dotnet test RestSharp.slnx -c Debug | ||
|
|
||
| # Run tests for a specific TFM | ||
| dotnet test RestSharp.slnx -f net9.0 | ||
|
|
||
| # Run a single test by fully-qualified name | ||
| dotnet test test/RestSharp.Tests/RestSharp.Tests.csproj --filter "FullyQualifiedName=RestSharp.Tests.ObjectParserTests.ShouldUseRequestProperty" -f net8.0 | ||
|
|
||
| # Pack | ||
| dotnet pack src/RestSharp/RestSharp.csproj -c Release -o nuget -p:IncludeSymbols=true -p:SymbolPackageFormat=snupkg | ||
| ``` | ||
|
|
||
| **Note:** `dotnet test` with `.slnx` does not work with `net8.0`. To run tests targeting `net8.0`, use individual project files: `dotnet test test/RestSharp.Tests/RestSharp.Tests.csproj -f net8.0` |
Contributor
There was a problem hiding this comment.
2. Slnx/net8 test guidance conflict 🐞 Bug ⛯ Reliability
CLAUDE.md recommends dotnet test RestSharp.slnx -c Debug (“Run all tests”), but also states dotnet test with .slnx does not work with net8.0. Since the .slnx includes test projects that multi-target net8.0, the guidance is internally inconsistent/ambiguous and likely to confuse or send users into a failing workflow.
Agent Prompt
### Issue description
`CLAUDE.md` currently recommends running all tests via `dotnet test RestSharp.slnx -c Debug` while also stating `.slnx` tests don’t work with `net8.0`. Because test projects in the `.slnx` multi-target `net8.0`, this is contradictory/ambiguous guidance.
### Issue Context
The `.slnx` includes test projects and the shared test props multi-target `net8.0`, so the doc should clearly communicate a working set of commands (and precisely what combination is known to fail).
### Fix Focus Areas
- CLAUDE.md[7-25]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Test Results 42 files 42 suites 17m 48s ⏱️ Results for commit d7820fc. |
RestResponse types have public setters on all properties. Remove the incorrect "immutable" label and clarify what [GenerateClone] actually does. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.slnxsolution formatdotnet testwith.slnxdoes not work withnet8.0(use project files instead)Fixes #2359
🤖 Generated with Claude Code