Surface root cause in ErrorMessage for wrapped exceptions

[alexeyzimarev]

Summary

• Use exception.GetBaseException().Message instead of exception.Message for ErrorMessage in both GetErrorResponse and AddException
• This surfaces the actual root cause (e.g. TLS/SSL errors) instead of generic wrapper messages like "An error occurred while sending the request"
• The full exception chain remains preserved in ErrorException

Fixes #2278

Test plan

• Project builds successfully
• No existing tests assert on ErrorMessage string content
• Verify TLS error scenarios show specific SSL error messages in ErrorMessage
• Verify ErrorException still contains the full exception chain

🤖 Generated with Claude Code

[qodo-free-for-open-source-projects]

Review Summary by Qodo

Surface root cause in ErrorMessage for wrapped exceptions

🐞 Bug fix

Walkthroughs

Description

• Surface root cause exception message instead of generic wrapper
• Use GetBaseException().Message for ErrorMessage in error handling
• Preserve full exception chain in ErrorException property
• Improves diagnostics for TLS/SSL and other wrapped exceptions

Diagram

flowchart LR
  A["Exception with wrapper message"] -->|GetBaseException| B["Root cause exception"]
  B -->|Extract Message| C["Specific error details"]
  A -->|Preserve chain| D["ErrorException property"]
  C --> E["ErrorMessage property"]

Loading

File Changes

1. src/RestSharp/Response/RestResponseBase.cs 🐞 Bug fix +1/-1

Use base exception message in AddException

• Changed AddException method to use exception.GetBaseException().Message instead of
 exception.Message
• Surfaces the innermost exception message to reveal root causes
• Maintains full exception chain in ErrorException field

src/RestSharp/Response/RestResponseBase.cs

---

2. src/RestSharp/RestClient.Async.cs 🐞 Bug fix +1/-1

Use base exception message in GetErrorResponse

• Updated GetErrorResponse method to use exception.GetBaseException().Message for ErrorMessage
• Replaces generic wrapper message with actual root cause message
• Improves error diagnostics for wrapped exceptions like TLS/SSL failures

src/RestSharp/RestClient.Async.cs

---

[qodo-free-for-open-source-projects]

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0) 📎 Requirement gaps (0)

1. Inconsistent timeout classification 🐞 Bug ✓ Correctness

Description

GetErrorResponse now sets ErrorMessage from exception.GetBaseException().Message, but still
classifies TimedOut/Aborted using the outer exception type and checks the outer exception.Message
for a timeout substring. If a timeout/cancellation is wrapped, callers can see a root-cause timeout
message while ResponseStatus is misclassified (e.g., Error/Aborted).

Code

src/RestSharp/RestClient.Async.cs[R65-71]

            ResponseStatus = exception is OperationCanceledException
                ? TimedOut() ? ResponseStatus.TimedOut : ResponseStatus.Aborted
                : ResponseStatus.Error,
-            ErrorMessage   = exception.Message,
+            ErrorMessage   = exception.GetBaseException().Message,
            ErrorException = exception
        };

Evidence

The method mixes base-exception messaging with wrapper-exception classification: ErrorMessage is
derived from GetBaseException(), but ResponseStatus and TimedOut() operate on the original (possibly
wrapping) exception. This can produce inconsistent response semantics when the base exception
differs from the wrapper (the scenario this PR explicitly targets: wrapped exceptions).

src/RestSharp/RestClient.Async.cs[63-75]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
`GetErrorResponse` now sets `ErrorMessage` from `exception.GetBaseException().Message`, but timeout/abort detection still uses the *outer* exception (`exception is OperationCanceledException` and `exception.Message.Contains(...)`). With wrapped exceptions, this can misclassify `ResponseStatus` while showing a root-cause message.

### Issue Context
This PR’s goal is to surface the real root cause for wrapped exceptions; status classification should align with the same root cause to avoid inconsistent behavior.

### Fix Focus Areas
- src/RestSharp/RestClient.Async.cs[63-75]

### Suggested direction
- Compute `var baseException = exception.GetBaseException();`
- Use `baseException` (or both `exception` and `baseException`) for:
 - `ResponseStatus` type checks (e.g., cancellation/timeout)
 - `TimedOut()` message checks (if you keep the substring heuristic)
- Consider preferring `timeoutToken.IsCancellationRequested` + exception type checks over message substring matching, if feasible.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

---

ⓘ The new review experience is currently in Beta. Learn more

[cloudflare-workers-and-pages]

Deploying restsharp with    Cloudflare Pages

Latest commit:	5b1de23
Status:	✅  Deploy successful!
Preview URL:	https://c1556ef6.restsharp.pages.dev
Branch Preview URL:	https://fix-innermost-error-message.restsharp.pages.dev

View logs

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

Test Results

   42 files     42 suites   17m 49s ⏱️
  505 tests   505 ✅ 0 💤 0 ❌
3 530 runs  3 530 ✅ 0 💤 0 ❌

Results for commit 5b1de23.