perf(rule_engine): Read file data via overlapped I/O#632
Merged
rabbitstack merged 5 commits intomasterfrom Feb 28, 2026
Merged
Conversation
2c722eb to
4ac254a
Compare
Make async I/O requests to the file system and implement cancellations in case of locking scenarios.
4ac254a to
6c83564
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this PR / why it is needed?
Performing I/O operations in the event trace callback can quickly create a bottleneck and cause delayed event processing. To mitigate this unwanted effect, file information parsing is now performed in a lazy manner when the condition is evaluated. Additionally, the file data is read via overlapped I/O driven by a timeout. The rule conditions are rearranged to defer filter evaluation as late as possible.
What type of change does this PR introduce?
/kind bug-fix (non-breaking change which fixes an issue)
/kind improvement
Any specific area of the project related to this PR?
/area telemetry
/area rule-engine
Special notes for the reviewer
Does this PR introduce a user-facing change?