toolkit: convert WFN.Value to value receiver#1278
Conversation
When using the go sql driver WFN will not be recognized as a driver.Valuer (only *WFN). As WFN is direct value in claircore's structs this makes it fiddly, the change allows both pointer and value to benefit from Value(). Signed-off-by: crozzy <joseph.crosland@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1278 +/- ##
=======================================
Coverage 56.42% 56.43%
=======================================
Files 233 233
Lines 15355 15355
=======================================
+ Hits 8664 8665 +1
+ Misses 5806 5803 -3
- Partials 885 887 +2 ☔ View full report in Codecov by Sentry. |
53712a5 to
3542340
Compare
|
I think this was the case in the initial migration into the toolkit module and that broke things -- double-check the git log |
|
It looks like it was added here, and existed in the old package at the same time here, with the value receiver, I can't seem to find any specifics about why the method was changed. If I'm thinking about this correctly this should never be an issue with pgx and issues will only surface when implementing a datastore that leverages the |
When using the go sql driver WFN will not be recognized as a driver.Valuer (only *WFN). As WFN is direct value in claircore's structs this makes it fiddly, the change allows both pointer and value to benefit from Value().