Skip to content

Comments

Only use chr(30) and chr(31) delimiters in cirq-ionq#7699

Draft
splch wants to merge 3 commits intoquantumlib:mainfrom
splch:no-ctrl-chars-in-json
Draft

Only use chr(30) and chr(31) delimiters in cirq-ionq#7699
splch wants to merge 3 commits intoquantumlib:mainfrom
splch:no-ctrl-chars-in-json

Conversation

@splch
Copy link
Contributor

@splch splch commented Oct 10, 2025

  • update tests to remove\u* and \x*

relates to #5216

@github-actions github-actions bot added the size: S 10< lines changed <50 label Oct 10, 2025
@splch splch closed this Oct 10, 2025
@splch splch force-pushed the no-ctrl-chars-in-json branch from f66d46b to e8e79bb Compare October 10, 2025 01:29
@github-actions github-actions bot added Size: XS <10 lines changed and removed size: S 10< lines changed <50 labels Oct 10, 2025
@splch splch reopened this Oct 10, 2025
@github-actions github-actions bot added size: S 10< lines changed <50 and removed Size: XS <10 lines changed labels Oct 10, 2025
@splch splch changed the title replace chr(30) and chr(31) delimiters with k and t only use chr(30) and chr(31) delimiters Oct 10, 2025
@codecov
Copy link

codecov bot commented Oct 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.38%. Comparing base (8dd8a8f) to head (01c892c).
⚠️ Report is 94 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7699      +/-   ##
==========================================
- Coverage   99.38%   99.38%   -0.01%     
==========================================
  Files        1090     1090              
  Lines       98300    98301       +1     
==========================================
  Hits        97695    97695              
- Misses        605      606       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mhucka
Copy link
Contributor

mhucka commented Oct 13, 2025

@splch Thank you for your work on this! When you get a chance, could you update the title of this PR to mention that this is for cirq-ionq, and also add a bit more explanation to the PR description? This will help future contributors and maintainers when reading and searching through past work.

@mhucka mhucka changed the title only use chr(30) and chr(31) delimiters Only use chr(30) and chr(31) delimiters in cirq-ionq Nov 23, 2025
@mhucka
Copy link
Contributor

mhucka commented Nov 23, 2025

@splch I'm not sure if this draft PR is still something planned. It looks like the associated issue was closed. Maybe this should be closed too? (No biggie either way; just going around and checking up on things.)

@github-actions
Copy link

This pull request has been automatically labeled as stale because 90 days have passed without comments or other activity. If no further activity occurs and the status/stale label is not removed by a maintainer within 60 days, this pull request will be closed. If you would like to restore its active status, please leave a comment here; doing so will cause the staleness handler to remove the label.

If you have questions or feedback about this process, we welcome your input. You can open a new issue to let us know (please also reference this issue there, for continuity), or reach out to the project maintainers at quantum-oss-maintainers@google.com.

@github-actions github-actions bot added status/stale This has been closed due to inactivity for an extended period of time. and removed status/stale This has been closed due to inactivity for an extended period of time. labels Feb 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: S 10< lines changed <50

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants