Remove prohibit_none_typevar_overlap#20864
Merged
hauntsaninja merged 2 commits intopython:masterfrom Feb 23, 2026
Merged
Conversation
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
hauntsaninja
added a commit
to hauntsaninja/mypy
that referenced
this pull request
Feb 23, 2026
Requires python#20864 to work Fixes python#20628
This was referenced Feb 23, 2026
JukkaL
reviewed
Feb 23, 2026
| @@ -9322,13 +9322,7 @@ def is_overlapping_types_for_overload(left: Type, right: Type) -> bool: | |||
| # def foo(x: None) -> None: .. | |||
| # @overload | |||
| # def foo(x: T) -> Foo[T]: ... | |||
Collaborator
There was a problem hiding this comment.
Does this example in the comment still work (is there an existing test case for this)?
Collaborator
Author
There was a problem hiding this comment.
Yes, see testOverloadDetectsPossibleMatchesWithGenerics and #15846
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed this seems to be useless while investigating a fix for narrowing with TypeVars