gh-145202: Fix segfault in unicodedata.iter_graphemes when cleared by GC#145203
Closed
gourijain029-del wants to merge 1 commit intopython:mainfrom
Closed
gh-145202: Fix segfault in unicodedata.iter_graphemes when cleared by GC#145203gourijain029-del wants to merge 1 commit intopython:mainfrom
gourijain029-del wants to merge 1 commit intopython:mainfrom
Conversation
Member
|
#145216 is an alternative solution. I do not think we need |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a segmentation fault in
unicodedata.iter_graphemesand its segment objects, which occurred when the objects were cleared by the garbage collector before being deallocated.In Modules/unicodedata.c, both
GraphemeBreakIteratorandSegmentObjecthavetp_clearimplementations that set their string references to NULL. However, their deallocators were usingPy_DECREFinstead ofPy_XDECREF. This led to a crash if a GC cycle (or interpreter shutdown) cleared the objects before they reached the deallocation path.I've updated GBI_dealloc and Segment_dealloc to use
Py_XDECREFto safely handle these NULL references.Fixes gh-145202.