gh-145098: Run Apple Silicon macOS CI on macos-26 (Tahoe)#145099
gh-145098: Run Apple Silicon macOS CI on macos-26 (Tahoe)#145099clintonsteiner wants to merge 1 commit intopython:mainfrom
Conversation
hugovk
left a comment
There was a problem hiding this comment.
I'm curious if there's any performance difference between this and the previous one, can you compare times?
Also noting this image is still in beta but should be GA "around November" [2025], "before Xcode 26.3 releases" [20 Feb], "late February / early March, but depends on Xcode 26.4 behavior in general, so no promises".
I don't see this as a blocker as long as everything we need is in there.
Misc/NEWS.d/next/Build/2026-02-22-12-00-00.gh-issue-145098.n7Qk2m.rst
Outdated
Show resolved
Hide resolved
|
webknjaz
left a comment
There was a problem hiding this comment.
Bumping the OS seems fine, although the downloader refactoring feels standalone..
|
My concern is less about speed, and more about reliability. For background - there is no issue running CPython on macOS-26. This is entirely a GitHub Actions issue. The macOS-15 runner has proven to be massively unreliable, and I haven't seen any movement on actions/runner-images#12777 or actions/runner-images#13275/actions/runner-images#13459 that suggests those issues have been fixed. Before this lands, I'd want to see a dozen or so re-runs to give some confidence that the simulator boot reliability issues we've seen on macOS-15 have been resolved on macOS-26. I also share the concern about conflating the downloading change with the CI change - is there a direct connection with the macOS runner here? The comment about "some runner/proxy setups" suggests it might be... but it's not clear if this is only to address an issue you've seen locally. |
|
I changed the download run probably due to unreliability of the runner, failed downloads twice and didn't know if it was a regression in the os of the runner's curl capability @freakboy3742 |
GitHub Actions failing downloads is a fairly common, but entirely inconsistent phenomenon. I've seen errors from GitHub accessing GitHub downloads. Unless you have concrete evidence that the issue is HTTP 1.1 compliance, I'd rather not complicate that section of code (or at least defer it to a separate PR, where we can address the same issue on other platforms like Android and Emscripten). |
|
@freakboy3742 agreed, I had just pushed a revert a minute ago actually |
|
@clintonsteiner Please can you resolve the conflict in And revert the unrelated changes to |
|
@hugovk done, thank you! |
savannahostrowski
left a comment
There was a problem hiding this comment.
LGTM for jit.yml but also in general!
freakboy3742
left a comment
There was a problem hiding this comment.
Broadly looks good; a couple of specific suggestions that might impact testing time. All evidence I've seen says there's a very restricted set of images that are pre-warmed, and that pre-warming is good for up to 10 minutes of test time.
I also want to see the iOS job pass a dozen times in succession before this is merged - historically, GitHub's iOS runners are very inconsistent, and I don't want to merge this only to have to revert it because it didn't trigger
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase And if you don't make the requested changes, you will be poked with soft cushions! |
|
I have made the requested changes; please review again. |
|
Thanks for making the requested changes! @savannahostrowski, @freakboy3742: please review the changes made to this pull request. |
44926f1 to
9c84da9
Compare
|
@clintonsteiner Please don't force-push to branches - when you do that, we lose all the history of past commits. We use squashed commits when a PR is accepted, so there's no problem with having a "dirty" commit history on a PR. I was in the middle of doing some stress testing of the CI - and, as suspected, on the 9th re-run of the iOS test suite, we got the failure that there are "no matching simulators". So - as I feared, there's about a 10% failure rate associated with the macOS-26 runner, which matches what we saw with the macOS-15 runner, but doesn't happen with the macOS-14 runner. |
Uh oh!
There was an error while loading. Please reload this page.