Conversation
Contributor
|
🤖 Hi @kmvanbrunt, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1586 +/- ##
==========================================
+ Coverage 99.15% 99.42% +0.26%
==========================================
Files 20 20
Lines 4616 4665 +49
==========================================
+ Hits 4577 4638 +61
+ Misses 39 27 -12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
|
🤖 I'm sorry @kmvanbrunt, but I was unable to process your request. Please see the logs for more details. |
tleonhardt
requested changes
Feb 25, 2026
| """Contents of an asynchonous alert which display while user is at prompt. | ||
|
|
||
| :param msg: an optional message to be printed above the prompt. | ||
| :param prompt: an optional string to dynamically replace the current prompt. |
Member
There was a problem hiding this comment.
Recommend documenting timestamp parameter as well in the docstring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced
async_alert()andasync_update_prompt()with a single function calledadd_alert(). This new function is thread-safe and does not require you to acquire a mutex before calling it like the previous functions did.