Skip to content

AnchoredOverlay: Add support for CSS anchor positioning#7604

Draft
TylerJDev wants to merge 21 commits intomainfrom
tylerjdev/css-anchor-positioning
Draft

AnchoredOverlay: Add support for CSS anchor positioning#7604
TylerJDev wants to merge 21 commits intomainfrom
tylerjdev/css-anchor-positioning

Conversation

@TylerJDev
Copy link
Member

@TylerJDev TylerJDev commented Feb 26, 2026

Closes https://github.com/github/primer/issues/6446

  • Added support for CSS Anchor Positioning in AnchoredOverlay, gated by the primer_react_css_anchor_positioning feature flag.
  • Updated ActionMenu to ensure that the anchor button receives the correct anchor class for CSS anchor positioning, and improved merging of class names between anchor and button props.
  • Added new stories to AnchoredOverlay.features.stories.tsx to demonstrate anchor positioning in various layouts, including centered overlays, grid layouts, within dialogs (including nested and overflowing dialogs), scroll containers, and sticky headers.

Changelog

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot
Copy link

changeset-bot bot commented Feb 26, 2026

⚠️ No Changeset found

Latest commit: 9c79821

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Feb 26, 2026
@github-actions
Copy link
Contributor

⚠️ Action required

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the integration-tests: skipped manually label to skip these checks.

@primer
Copy link
Contributor

primer bot commented Feb 26, 2026

🤖 Lint and formatting issues have been automatically fixed and committed to this PR.

@github-actions github-actions bot temporarily deployed to storybook-preview-7604 February 26, 2026 22:32 Inactive
@primer
Copy link
Contributor

primer bot commented Feb 26, 2026

🤖 Lint issues have been automatically fixed and committed to this PR.

@primer
Copy link
Contributor

primer bot commented Feb 26, 2026

🤖 Lint issues have been automatically fixed and committed to this PR.

@primer
Copy link
Contributor

primer bot commented Feb 27, 2026

🤖 Lint and formatting issues have been automatically fixed and committed to this PR.

@github-actions github-actions bot temporarily deployed to storybook-preview-7604 February 27, 2026 02:10 Inactive
@primer
Copy link
Contributor

primer bot commented Feb 27, 2026

🤖 Lint issues have been automatically fixed and committed to this PR.

@primer
Copy link
Contributor

primer bot commented Feb 27, 2026

🤖 Lint issues have been automatically fixed and committed to this PR.

@siddharthkp
Copy link
Member

🤖 Lint and formatting issues have been automatically fixed and committed to this PR.

it keeps saying that but where is the commit? 😅

@TylerJDev
Copy link
Member Author

🤖 Lint and formatting issues have been automatically fixed and committed to this PR.

it keeps saying that but where is the commit? 😅

The bot really doesn't like my PR 😆

@github-actions github-actions bot requested a deployment to storybook-preview-7604 February 27, 2026 15:42 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-7604 February 27, 2026 15:52 Inactive
@primer-integration
Copy link

👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/14804

@primer-integration
Copy link

Integration test results from github/github-ui:

Passed  CI   Passed
Passed  VRT   Passed
Passed  Projects   Passed

All checks passed!

@TylerJDev TylerJDev changed the title CSS anchor positioning AnchoredOverlay: Add support for CSS anchor positioning Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants