Skip to content

Push margin-top of TimelineBody +1px#7595

Closed
llastflowers wants to merge 11 commits intomainfrom
llastflowers/2252026/timeline-icon-alignment-fix
Closed

Push margin-top of TimelineBody +1px#7595
llastflowers wants to merge 11 commits intomainfrom
llastflowers/2252026/timeline-icon-alignment-fix

Conversation

@llastflowers
Copy link
Contributor

@llastflowers llastflowers commented Feb 25, 2026 •
edited
Loading

Relates to https://github.com/github/primer/issues/6438

Changelog

Changed

Added +1px to the margin-top of TimelineBody to improve visual alignment of elements

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Good test stories:

Merge checklist

@llastflowers llastflowers requested a review from a team as a code owner February 25, 2026 21:24
@changeset-bot
Copy link

changeset-bot bot commented Feb 25, 2026 •
edited
Loading

🦋 Changeset detected

Latest commit: 7343b42

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@primer/mcp Patch
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Feb 25, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2026

⚠️ Action required

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the integration-tests: skipped manually label to skip these checks.

Copilot AI reviewed Feb 25, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the Timeline component’s visual spacing to better align TimelineBody content with surrounding Timeline elements, addressing primer issue #6438.

Changes:

  • Increases TimelineBody top margin by 1px via calc() to improve vertical alignment.
  • Adds a targeted stylelint disable for the spacing rule on the updated declaration.

@llastflowers llastflowers added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Feb 25, 2026
@github-actions github-actions bot temporarily deployed to storybook-preview-7595 February 25, 2026 21:34 Inactive
@primer primer bot requested a review from a team as a code owner February 25, 2026 21:40
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Feb 25, 2026
@github-actions github-actions bot temporarily deployed to storybook-preview-7595 February 25, 2026 21:50 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-7595 February 26, 2026 02:37 Inactive
HiroAgustin
HiroAgustin reviewed Feb 26, 2026
View reviewed changes
@HiroAgustin
Copy link
Contributor

HiroAgustin commented Feb 26, 2026

@copilot add patch changeset

@primer-integration
Copy link

primer-integration bot commented Feb 26, 2026

👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/14686

@github-actions github-actions bot temporarily deployed to storybook-preview-7595 February 26, 2026 19:56 Inactive
@primer-integration
Copy link

primer-integration bot commented Feb 26, 2026

Integration test results from github/github-ui:

Passed  CI   Passed
Running  VRT   Running
Passed  Projects   Passed

@llastflowers llastflowers added the integration-tests: skipped manually Changes in this PR do not require an integration test label Feb 26, 2026
@llastflowers
Copy link
Contributor Author

llastflowers commented Feb 26, 2026

integration tests passing but VRT status is not reporting here. Added skip label to unblock this PR

@llastflowers llastflowers added this pull request to the merge queue Mar 3, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Mar 3, 2026
@llastflowers llastflowers added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Mar 3, 2026
liuliu-dev and others added 5 commits March 3, 2026 12:15
@liuliu-dev @primer @llastflowers
SegmentedControl: remove the wrong aria-label in storybook (#7603)
b2016cb 
Co-authored-by: primer[bot] <119360173+primer[bot]@users.noreply.github.com>
@lukasoppermann @github-advanced-security
@primer @llastflowers
Exposing lineHeight tokens in MCP & adding color to token conversion (#…
b0e77ac 
…7601)

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: primer[bot] <119360173+primer[bot]@users.noreply.github.com>
@francinelucca @llastflowers
chore: always render ActionMenu in viewport when inside Dialog under …
2347044 
…feature flag (#7524)

Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
@hectahertz @llastflowers
perf(Spinner): replace Web Animations API with CSS animation-delay sy…
0246cca 
…nc (#7550)
@iansan5653
@primer @llastflowers
Extract reusable "descendant registry" pattern from ActionBar, with…
7343b42 
… new support for reordering elements (#7585)

Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: iansan5653 <2294248+iansan5653@users.noreply.github.com>
Co-authored-by: primer[bot] <119360173+primer[bot]@users.noreply.github.com>
@llastflowers llastflowers deleted the llastflowers/2252026/timeline-icon-alignment-fix branch March 3, 2026 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@HiroAgustin HiroAgustin HiroAgustin approved these changes

@francinelucca francinelucca francinelucca approved these changes

@lukasoppermann lukasoppermann Awaiting requested review from lukasoppermann

Assignees

No one assigned

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm integration-tests: skipped manually Changes in this PR do not require an integration test update snapshots 🤖 Command that updates VRT snapshots on the pull request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@llastflowers @HiroAgustin @francinelucca @liuliu-dev @lukasoppermann @hectahertz @iansan5653