Open
Conversation
asottile
reviewed
Feb 20, 2026
| 'zsh': {'text', 'shell', 'zsh'}, | ||
| } | ||
| EXTENSIONS_NEED_BINARY_CHECK = { | ||
| 'entitlements': {'plist', 'entitlements'}, |
Member
There was a problem hiding this comment.
can this actually be a binary file? all the examples I see online are either empty or xml
Contributor
Author
There was a problem hiding this comment.
I haven't seen any examples of it being binary, but the link documentation only says it must be a property list, aka plist file, without specifying the flavour.
I couldn't find any docs / forum threads / SO questions that would have a definitive answer either way, so it seems safer to make identify autodetect textness, just like other plists.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Format documentation: https://developer.apple.com/documentation/bundleresources/entitlements
Relevant quote: