Merged
Conversation
ProjectMutilation
force-pushed
the
fix-ruff-issues
branch
from
901c3cb to
fcc6488
Compare
ProjectMutilation
force-pushed
the
fix-ruff-issues
branch
from
fcc6488 to
c56e94a
Compare
Signed-off-by: Maksim Korotkov <m.korotkov@postgrespro.ru>
ProjectMutilation
force-pushed
the
fix-ruff-issues
branch
from
c56e94a to
5b8aa0a
Compare
dmitry-lipetsk
approved these changes
Feb 24, 2026
src/impl/port_manager__this_host.py
Outdated
|
|
||
| if __class__.sm_single_instance is not None: | ||
| assert type(__class__.sm_single_instance) == __class__ # noqa: E721 | ||
| assert isinstance(__class__.sm_single_instance, __class__) |
Collaborator
There was a problem hiding this comment.
Зачем ты мне сюда isinstance притащил? )
src/impl/port_manager__this_host.py
Outdated
| __class__.sm_single_instance = __class__() | ||
| assert __class__.sm_single_instance is not None | ||
| assert type(__class__.sm_single_instance) == __class__ # noqa: E721 | ||
| assert isinstance(__class__.sm_single_instance, __class__) |
Collaborator
There was a problem hiding this comment.
я вообще сторонник строгих проверок, если условия не требуют обратного )
src/backup.py
Outdated
|
|
||
| assert node is not None | ||
| assert type(node) == self.original_node.__class__ # noqa: E721 | ||
| assert isinstance(node, self.original_node.__class__) |
src/backup.py
Outdated
|
|
||
| assert node is not None | ||
| assert type(node) == self.original_node.__class__ # noqa: E721 | ||
| assert isinstance(node, self.original_node.__class__) |
Collaborator
There was a problem hiding this comment.
Suggested change
| assert isinstance(node, self.original_node.__class__) | |
| assert type(node) is self.original_node.__class__ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.