Remove redundant conftest.py to fix compatibility with pytest 9#5521
Open
thunze wants to merge 1 commit intoplotly:mainfrom
Open
Remove redundant conftest.py to fix compatibility with pytest 9#5521thunze wants to merge 1 commit intoplotly:mainfrom
conftest.py to fix compatibility with pytest 9#5521thunze wants to merge 1 commit intoplotly:mainfrom
Conversation
`pytest_ignore_collect` takes only `collection_path` starting with pytest 9. Most of the paths referenced in `plotly/conftest.py` don't exist anymore and wouldn't be collected anyway, so we can just remove the file. https://docs.pytest.org/en/latest/deprecations.html#py-path-local-arguments-for-hooks-replaced-with-pathlib-path
thunze
force-pushed
the
redundant-conftest
branch
from
9531e7f to
78f1b10
Compare
thunze
changed the title
np.isin instead of np.in1d to fix numpy 2.4 test compatibilityconftest.py to fix compatibility with pytest 9
thunze
added a commit
to thunze/nixpkgs
that referenced
this pull request
Feb 23, 2026
`pytest_ignore_collect` takes only `collection_path` starting with pytest 9 [1]. Most of the paths referenced in `plotly/conftest.py` don't exist anymore and wouldn't be collected anyway, so we can just remove the file. Upstream PR: plotly/plotly.py#5521 [1] https://docs.pytest.org/en/latest/deprecations.html#py-path-local-arguments-for-hooks-replaced-with-pathlib-path
This was referenced Feb 23, 2026
Stebalien
pushed a commit
to Stebalien/nixpkgs
that referenced
this pull request
Feb 24, 2026
`pytest_ignore_collect` takes only `collection_path` starting with pytest 9 [1]. Most of the paths referenced in `plotly/conftest.py` don't exist anymore and wouldn't be collected anyway, so we can just remove the file. Upstream PR: plotly/plotly.py#5521 [1] https://docs.pytest.org/en/latest/deprecations.html#py-path-local-arguments-for-hooks-replaced-with-pathlib-path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pytest_ignore_collecttakes onlycollection_pathstarting with pytest 9. Most of the paths referenced inplotly/conftest.pydon't exist anymore and wouldn't be collected anyway, so we can just remove the file (I think?).I ran into this issue while running
pytestinstead ofpytest testswith pytest 9.0.2 installed.https://docs.pytest.org/en/latest/deprecations.html#py-path-local-arguments-for-hooks-replaced-with-pathlib-path
Code PR
plotly.graph_objects, my modifications concern the code generator and not the generated files.