Skip to content

SPOC-456. Fix TAP test credentials mismatch in zodan_sync workflow#365

Merged
mason-sharp merged 1 commit intomainfrom
spoc-456
Mar 3, 2026
Merged

SPOC-456. Fix TAP test credentials mismatch in zodan_sync workflow#365
mason-sharp merged 1 commit intomainfrom
spoc-456

Conversation

@danolivo
Copy link
Contributor

@danolivo danolivo commented Mar 2, 2026

  • Unset PGUSER, PGPASSWORD, PGDATABASE in run-spock-tap.sh after
    sourcing .bashrc to prevent "role admin does not exist" errors — TAP tests
    create their own PostgreSQL instances via initdb where only the OS user
    (pgedge) exists as superuser
  • Remove unused "Set up docker compose" step from zodan_sync.yml since the
    workflow only uses docker build/docker run, not docker compose

Unset PGUSER, PGPASSWORD, PGDATABASE in run-spock-tap.sh after sourcing
.bashrc, since TAP tests create their own PostgreSQL instances via initdb
with the OS user (pgedge) as superuser, not the Docker "admin" role.

Also remove the unused "Set up docker compose" step from zodan_sync.yml.
@danolivo danolivo self-assigned this Mar 2, 2026
@danolivo danolivo added the bug Something isn't working label Mar 2, 2026
@coderabbitai
Copy link

coderabbitai bot commented Mar 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 33a21c9 and 0b4ab53.

📒 Files selected for processing (2)
  • .github/workflows/zodan_sync.yml
  • tests/docker/run-spock-tap.sh
💤 Files with no reviewable changes (1)
  • .github/workflows/zodan_sync.yml

📝 Walkthrough

Walkthrough

This pull request modifies the Docker test environment configuration by removing the docker compose setup action from the GitHub Actions workflow and adding PostgreSQL environment variable cleanup to the test runner script to prevent role-related errors during test execution.

Changes

Cohort / File(s) Summary
CI/CD Workflow
.github/workflows/zodan_sync.yml
Removed the docker compose setup action (docker/setup-compose-action@... v1) and its configuration block from the GitHub Actions workflow.
Test Environment Setup
tests/docker/run-spock-tap.sh
Added environment variable cleanup to unset PGUSER, PGPASSWORD, and PGDATABASE before test execution to prevent PostgreSQL role errors.

Poem

🐰 A rabbit hops through workflows clean,
Removing setup steps once seen,
Then clears the variables with care,
So tests run smoothly everywhere,
No roles lost, just clarity!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly references the main issue (SPOC-456) and summarizes the primary fix: resolving TAP test credentials mismatch in the zodan_sync workflow, which matches the changeset.
Description check ✅ Passed The description directly explains both changes in the pull request: unsetting PostgreSQL environment variables in run-spock-tap.sh and removing the unused docker compose setup step from zodan_sync.yml.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch spoc-456

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mason-sharp mason-sharp merged commit 487d140 into main Mar 3, 2026
10 checks passed
@mason-sharp mason-sharp deleted the spoc-456 branch March 3, 2026 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants