SPOC-456. Fix TAP test credentials mismatch in zodan_sync workflow#365
SPOC-456. Fix TAP test credentials mismatch in zodan_sync workflow#365mason-sharp merged 1 commit intomainfrom
Conversation
Unset PGUSER, PGPASSWORD, PGDATABASE in run-spock-tap.sh after sourcing .bashrc, since TAP tests create their own PostgreSQL instances via initdb with the OS user (pgedge) as superuser, not the Docker "admin" role. Also remove the unused "Set up docker compose" step from zodan_sync.yml.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThis pull request modifies the Docker test environment configuration by removing the docker compose setup action from the GitHub Actions workflow and adding PostgreSQL environment variable cleanup to the test runner script to prevent role-related errors during test execution. Changes
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PGUSER,PGPASSWORD,PGDATABASEinrun-spock-tap.shaftersourcing
.bashrcto prevent "role admin does not exist" errors — TAP testscreate their own PostgreSQL instances via
initdbwhere only the OS user(
pgedge) exists as superuserzodan_sync.ymlsince theworkflow only uses
docker build/docker run, notdocker compose