Enable overriding inheritance per-pattern#6
Open
bryce-gilhome wants to merge 6 commits intopattern-lab:masterfrom
bryce-gilhome:master
Open
Enable overriding inheritance per-pattern#6bryce-gilhome wants to merge 6 commits intopattern-lab:masterfrom bryce-gilhome:master
bryce-gilhome wants to merge 6 commits intopattern-lab:masterfrom
bryce-gilhome:master
Conversation
…efault (if enabled), and a "data-inheritance" key that can be set in pattern data to override that default setting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a config option dataInheritance.default (bool) which describes the default inheritance behaviour (if the plugin is enabled) - i.e. by default, either inherit lineage pattern data or not - and a 'data-inheritance' key (bool) that can be set in pattern data to override that default.
e.g. if dataInheritance.default is false, and pattern 'foobar' has data 'data-inheritance: true', then any pattern including foobar will use the inherited data. Likewise if the default is true, all included patterns will use inherited data, unless their data contains 'data-inheritance: false'.