Instrument sled-agent http endpoints with oximeter latency tracking.#9937
Merged
Instrument sled-agent http endpoints with oximeter latency tracking.#9937
Conversation
Contributor
This is really nice. For those that want to see it connect to VPN and log in with Google. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: feel free to tell me this a bad idea! I was putting together a dashboard on http metrics from the rack, and I noticed that sled-agent isn't instrumented. Without thinking about it too hard, my feeling is that we should instrument all the http services, unless there's a specific reason not to. Claude was able to do the repetitive work of instrumenting each handler, so if we don't want to do this, we won't have spent much time on the experiment.