Merged
Conversation
rcgoodfellow
force-pushed
the
ry/dendrite-220
branch
from
1f0447e to
7df6549
Compare
rcgoodfellow
force-pushed
the
ry/dendrite-220
branch
2 times, most recently
from
5c4369d to
04d9c02
Compare
rcgoodfellow
force-pushed
the
ry/dendrite-220
branch
from
04d9c02 to
e15c3b5
Compare
zeeshanlakhani
added a commit
that referenced
this pull request
Mar 2, 2026
This includes a few changes I was already working on in relation to #9898. This comes after testing with a feature-gated (for multicast) dpd binary. There's a minor follow-up (oxidecomputer/dendrite#232) that I'll work in after this. - Use actual group tags from DPD responses instead of hardcoded "nexus" - Rename IntoUnderlayMulticastIpv6 -> IntoUnderlayMulticast (shorter), fits trait definition / more accurate - Pass MulticastTag as parameter to dpd_update_external_or_create - Use existing_tag.try_into() / current_tag.try_into() for tag usage - Nit: dpd_state_matches_tag to use as_str() comparison - Fix: IpSrc::Subnet -> IpSrc::Any (new dendrite API) - Fix: SwitchLocation import (moved to sled_agent_types) - Remove unused multicast type imports
Collaborator
zeeshanlakhani
left a comment
zeeshanlakhani
left a comment
There was a problem hiding this comment.
For the multicast-side, as I've been running those tests against an actual feature-built DPD binary, so I put up a PR against your work @rcgoodfellow #9950. I hope that's ok.
This includes a few changes I was already working on in relation to #9898. This comes after testing with a feature-gated (for multicast) dpd binary. There's a minor follow-up (oxidecomputer/dendrite#232) that I'll work in after this. - Use actual group tags from DPD responses instead of hardcoded "nexus" - Rename IntoUnderlayMulticastIpv6 -> IntoUnderlayMulticast (shorter), fits trait definition / more accurate - Pass MulticastTag as parameter to dpd_update_external_or_create - Use existing_tag.try_into() / current_tag.try_into() for tag usage - Nit: dpd_state_matches_tag to use as_str() comparison - Fix: IpSrc::Subnet -> IpSrc::Any (new dendrite API) - Fix: SwitchLocation import (moved to sled_agent_types) - Remove unused multicast type imports
zeeshanlakhani
approved these changes
Mar 2, 2026
smklein
reviewed
Mar 2, 2026
| // tokio_postgres::config::Config parser to include in the error | ||
| // message. | ||
| let error = "foo".parse::<PostgresConfigWithUrl>().unwrap_err(); | ||
| assert!(error.to_string().contains("unexpected EOF")); |
Collaborator
There was a problem hiding this comment.
Your change here seems totally reasonable to me; invalid connection string is describing the situation here accurately, and I don't think "unexpected EOF" even described the condition we were looking for before. It just happened to be the string emitted by the old postgres version.
Merged
smklein
added a commit
that referenced
this pull request
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.