Avoid manual translation of table names for softnpu#227
Open
Nieuwejaar wants to merge 1 commit intomainfrom
Open
Avoid manual translation of table names for softnpu#227Nieuwejaar wants to merge 1 commit intomainfrom
Nieuwejaar wants to merge 1 commit intomainfrom
Conversation
Nieuwejaar
commented
Feb 23, 2026
| } | ||
| if (!meta.dropped && meta.nat_egress_hit && !meta.is_mcast) { | ||
| if (!meta.dropped && meta.nat_egress_hit && | ||
| !meta.is_mcast && !meta.service_routed) { |
Collaborator
Author
There was a problem hiding this comment.
This is a cherry-picked commit from the dendrite#225 bugfix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This modifies dpd to use a
TableTypeenum to identify tables rather than passing around strings. This gets rid of the brittle, error-prone mapping of tofino's table names to softnpu's table names. We are now also using theCounterIdenum to track counters in places we were previously using strings.This seemed like a pretty simple change when I started, but the blast radius has turned out to be surprisingly large. Apologies.