✨ Add feature gate for registry+v1 bundle deploymentConfig#2527
✨ Add feature gate for registry+v1 bundle deploymentConfig#2527tmshort wants to merge 1 commit intooperator-framework:mainfrom
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
tmshort
changed the title
There was a problem hiding this comment.
Pull request overview
Adds a new alpha feature gate (DeploymentConfig) to control support for spec.config.inline.deploymentConfig in ClusterExtension resources, defaulting the capability off and enabling it only in experimental install paths.
Changes:
- Introduces
features.DeploymentConfig(alpha, defaultfalse) and wires it into operator-controller startup. - When disabled, removes
deploymentConfigfrom the registry+v1 bundle config schema prior to validation to surface an “unknown field” error. - Updates unit/e2e tests and experimental manifests/Helm values to enable and validate the behavior.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
internal/operator-controller/features/features.go |
Defines the new DeploymentConfig alpha feature gate. |
cmd/operator-controller/main.go |
Plumbs the feature gate into RegistryV1ManifestProvider creation. |
internal/operator-controller/applier/provider.go |
Gates schema acceptance + render option extraction for deploymentConfig. |
internal/operator-controller/applier/provider_test.go |
Ensures behavior is terminal-error when the gate is disabled; enables gate for existing tests. |
manifests/experimental.yaml |
Enables DeploymentConfig in experimental deployment args. |
manifests/experimental-e2e.yaml |
Enables DeploymentConfig in experimental-e2e deployment args. |
helm/experimental.yaml |
Enables DeploymentConfig in experimental Helm values. |
test/e2e/steps/hooks.go |
Adds the gate to the e2e feature-gate skip map (default false). |
test/e2e/features/install.feature |
Adds an e2e scenario asserting nodeSelector from deploymentConfig is applied. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2527 +/- ##
==========================================
- Coverage 72.04% 72.04% -0.01%
==========================================
Files 103 103
Lines 8690 8695 +5
==========================================
+ Hits 6261 6264 +3
- Misses 1946 1947 +1
- Partials 483 484 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ustomization Wraps the deploymentConfig API feature (spec.config.inline.deploymentConfig) behind a new Alpha feature gate so it can be disabled by default and is only enabled in experimental manifests. When the gate is disabled, deploymentConfig is removed from the bundle's config schema before validation, giving users a clear "unknown field" error rather than silently ignoring the configuration. Assisted-by: Claude Signed-off-by: Todd Short <tshort@redhat.com>
tmshort
force-pushed
the
config-api-fg
branch
from
5aa2d30 to
3fd9c27
Compare
| And ClusterExtensionRevision "${NAME}-1" has label "olm.operatorframework.io/owner-kind" with value "ClusterExtension" | ||
| And ClusterExtensionRevision "${NAME}-1" has label "olm.operatorframework.io/owner-name" with value "${NAME}" | ||
|
|
||
| @DeploymentConfig |
There was a problem hiding this comment.
Do we care about exercising each of the different deployment config options? (or maybe all of them at once?)
| matchLabels: | ||
| "olm.operatorframework.io/metadata.name": test-catalog | ||
| """ | ||
| Then ClusterExtension is rolled out |
There was a problem hiding this comment.
Maybe we don't care about whether it rolled out successfully as much as that the deployment exists and the spec matches what we want? maybe this gets tested on clusters that don't have linux nodes, or something like that?
Wraps the deploymentConfig API feature (spec.config.inline.deploymentConfig) behind a new Alpha feature gate so it can be disabled by default and is only enabled in experimental manifests.
When the gate is disabled, deploymentConfig is removed from the bundle's config schema before validation, giving users a clear "unknown field" error rather than silently ignoring the configuration.
Assisted-by: Claude
Description
Reviewer Checklist