SelectFeature should toggle features with box select#1444
Open
mdalbertsonjr wants to merge 1 commit intoopenlayers:masterfrom
Open
SelectFeature should toggle features with box select#1444mdalbertsonjr wants to merge 1 commit intoopenlayers:masterfrom
mdalbertsonjr wants to merge 1 commit intoopenlayers:masterfrom
Conversation
Fixed an issue and added a test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I recently ran into an issue with the SelectFeature control where features I had selected would toggle properly on click, but would not toggle at all under box select. I have added a condition for unselecting selected features in the selectBox method to implement this behavior if the toggle setting is enabled, and a simple unit test to verify that it works.