Merged
Conversation
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (37.50%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #8123 +/- ##
============================================
- Coverage 90.34% 90.32% -0.02%
+ Complexity 7647 7645 -2
============================================
Files 841 841
Lines 23007 23008 +1
Branches 2295 2296 +1
============================================
- Hits 20786 20783 -3
- Misses 1507 1509 +2
- Partials 714 716 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jack-berg
commented
Mar 5, 2026
| private static Stream<Arguments> exampleFiles() { | ||
| File configRepoRoot = new File(System.getenv("CONFIG_REPO_ROOT")); | ||
| File examplesDir = new File(configRepoRoot + "/examples/"); | ||
| File snippetsDir = new File(configRepoRoot + "/snippets/"); |
Member
Author
There was a problem hiding this comment.
This is cool. Declarative config split out kitchen-sink.yaml into a directory of small focused snippets. Here I add all the snippets to the set of example config files that we validate against.
antonio-mazzini
added a commit
to antonio-mazzini/opentelemetry-java
that referenced
this pull request
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating to the v1.0.0 of the schema.