Skip to content

tip+brush combination#2361

Open
Fil wants to merge 6 commits intofil/brush-datalessfrom
fil/brush+tip
Open

tip+brush combination#2361
Fil wants to merge 6 commits intofil/brush-datalessfrom
fil/brush+tip

Conversation

@Fil
Copy link
Contributor

@Fil Fil commented Feb 14, 2026

Using a simple signalling through a className on the svg, we disable the tip interaction during brushing.

@Fil Fil mentioned this pull request Feb 14, 2026
Fil added 3 commits February 20, 2026 11:59
Rationale: tip is more fundamental than brush, and other interactions (such as lasso) will want to do the same
# Conflicts:
#	src/interactions/brush.js
#	test/plots/brush.ts
@Fil Fil mentioned this pull request Feb 24, 2026
@Fil Fil requested a review from allisonhorst February 24, 2026 17:24
Copy link

@allisonhorst allisonhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If tooltip is already visible (hovering near a point) and I start brushing, that last tooltip remains visible. I expected the tooltip to disappear as soon as I start brushing. Clicking after brushing removes the lingering tooltip, and I'm able to hover to show the tooltip again. I would expect to be able to see the tooltip on hover immediately after I release the brush, without requiring the additional click.

brush-tip-plot.mp4

@Fil
Copy link
Contributor Author

Fil commented Feb 25, 2026

I think the new version fixes the behavior, at least it now feels a bit more natural to me.

@allisonhorst
Copy link

allisonhorst commented Feb 27, 2026

Checking on two things (both shown in the video below). Should I expect that:

  • Clicking when I'm hovering over a point will "stick" the tooltip to that point. In other words, if I click while hovering over a point, I can then continue moving the mouse around the chart but the tooltip stays put on the point I had clicked.
    • Follow-up question to above: Does the click action I describe above actually do anything to the data (like filter to just that point)?
  • Tooltips no longer appear when hovering over points within the brush area. I think this feels right, since the cursor changes to the 'move this around' shape so I don't expect to see the tooltip.
brush-tip-behavior.mp4

@Fil
Copy link
Contributor Author

Fil commented Feb 27, 2026

Yes, this is as expected, in the sense that the goal here is to make the brush mark work in conjunction with the tip (which sticks). Changing the tip behavior so it doesn't stick is covered by #1832

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants