Conversation
# Conflicts: # src/interactions/brush.js # test/plots/brush.ts
allisonhorst
left a comment
There was a problem hiding this comment.
If tooltip is already visible (hovering near a point) and I start brushing, that last tooltip remains visible. I expected the tooltip to disappear as soon as I start brushing. Clicking after brushing removes the lingering tooltip, and I'm able to hover to show the tooltip again. I would expect to be able to see the tooltip on hover immediately after I release the brush, without requiring the additional click.
brush-tip-plot.mp4
|
I think the new version fixes the behavior, at least it now feels a bit more natural to me. |
|
Checking on two things (both shown in the video below). Should I expect that:
brush-tip-behavior.mp4 |
|
Yes, this is as expected, in the sense that the goal here is to make the brush mark work in conjunction with the tip (which sticks). Changing the tip behavior so it doesn't stick is covered by #1832 |
Using a simple signalling through a className on the svg, we disable the tip interaction during brushing.