sqlite: optimize column name creation and text value encoding#61954
Open
thisalihassan wants to merge 1 commit intonodejs:mainfrom
Open
sqlite: optimize column name creation and text value encoding#61954thisalihassan wants to merge 1 commit intonodejs:mainfrom
thisalihassan wants to merge 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
6adb625 to
ff6a788
Compare
Use simdutf to detect ASCII text values and create them via NewFromOneByte for compact one-byte representation. Internalize column name strings with kInternalized so V8 shares hidden classes across row objects. Cache column names on StatementSync for iterate(), invalidated via SQLITE_STMTSTATUS_REPREPARE on schema changes. Refs: nodejs/performance#181
ff6a788 to
4fcb1ed
Compare
Contributor
Author
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #61954 +/- ##
==========================================
+ Coverage 88.84% 89.77% +0.93%
==========================================
Files 674 674
Lines 204957 205638 +681
Branches 39309 39415 +106
==========================================
+ Hits 182087 184605 +2518
+ Misses 15088 13273 -1815
+ Partials 7782 7760 -22
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Skip the full
UTF-8decode path for text values that are pure ASCII by validating withsimdutfand creatingOneByteV8 strings, halving memory.Internalizecolumn name strings so V8 shares hidden classes across row objects. Cache column names in theiterate()hot loop, invalidating on schema changes viaSQLITE_STMTSTATUS_REPREPARE.Benchmark: 30-run

Refs: nodejs/performance#181