Skip to content

Comments

fs: fix cpSync to handle non-ASCII characters#61950

Open
StefanStojanovic wants to merge 1 commit intonodejs:mainfrom
JaneaSystems:mefi-cpSync-fix
Open

fs: fix cpSync to handle non-ASCII characters#61950
StefanStojanovic wants to merge 1 commit intonodejs:mainfrom
JaneaSystems:mefi-cpSync-fix

Conversation

@StefanStojanovic
Copy link
Contributor

This PR fixes the problem described in the linked issue and adds a regression test for it.

Fixes: #61878

@StefanStojanovic StefanStojanovic added fs Issues and PRs related to the fs subsystem / file system. windows Issues and PRs related to the Windows platform. labels Feb 23, 2026
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Feb 23, 2026
@codecov
Copy link

codecov bot commented Feb 23, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.77%. Comparing base (da5efc4) to head (1a71ee2).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/node_file.cc 66.66% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #61950      +/-   ##
==========================================
+ Coverage   88.84%   89.77%   +0.93%     
==========================================
  Files         674      674              
  Lines      204957   205609     +652     
  Branches    39309    39410     +101     
==========================================
+ Hits       182087   184589    +2502     
+ Misses      15088    13264    -1824     
+ Partials     7782     7756      -26     
Files with missing lines Coverage Δ
src/node_file.cc 75.30% <66.66%> (+0.03%) ⬆️

... and 179 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. windows Issues and PRs related to the Windows platform.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fs.cpSync does not copy files if destination path has accented characters on Windows

3 participants