Fix fuse_pad_into_conv incorrectly fusing when Pad contains negative values#2841
Draft
Fix fuse_pad_into_conv incorrectly fusing when Pad contains negative values#2841
Conversation
Co-authored-by: justinchuby <11205048+justinchuby@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix optimization to handle negative pad values in Conv layer
Fix fuse_pad_into_conv incorrectly fusing when Pad contains negative values
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
fuse_pad_into_convoptimization would fuse aPadnode intoConveven whenpadscontained negative values (valid forPadas crop operations, but invalid forConv'spadsattribute), producing an invalid model.Changes
_fuse_pad_into_conv.py: Added a guard in_FuseConvPadBase.check()to bail out when any computed pad value is negative, preventing fusion that would produce an invalidConvnode:_fuse_pad_into_conv_test.py: Added a test case totest_unsupported_fuse_pad_into_convverifying that fusion is rejected when spatial pads are negative.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.