[Rewriter] Extend list of supported commutative operations#2741
Merged
justinchuby merged 1 commit intomicrosoft:mainfrom Mar 3, 2026
Merged
[Rewriter] Extend list of supported commutative operations#2741justinchuby merged 1 commit intomicrosoft:mainfrom
justinchuby merged 1 commit intomicrosoft:mainfrom
Conversation
Signed-off-by: Christoph Berganski <christoph.berganski@gmail.com>
justinchuby
approved these changes
Dec 21, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2741 +/- ##
=======================================
Coverage 70.09% 70.09%
=======================================
Files 226 226
Lines 27388 27389 +1
Branches 2781 2781
=======================================
+ Hits 19198 19199 +1
Misses 7234 7234
Partials 956 956 ☔ View full report in Codecov by Sentry. |
Collaborator
|
@gramalingam do you see potential performance impact with this change? |
gramalingam
reviewed
Dec 22, 2025
iksnagreb
added a commit
to iksnagreb/onnx-passes
that referenced
this pull request
Jan 3, 2026
Note: This tracks the not-yet-merged extended commutativity pattern PR, see microsoft/onnxscript#2741
Contributor
Author
|
I don't think I am responsible for the failing tests? |
|
+1 This is a blocker for our project. |
justinchuby
approved these changes
Mar 3, 2026
Collaborator
justinchuby
left a comment
justinchuby
left a comment
There was a problem hiding this comment.
Let's merge and see what happens
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.