Eliminate interpolation from workflows#63188
Merged
jakebailey merged 1 commit intomicrosoft:mainfrom Feb 23, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances security in GitHub Actions workflows by eliminating direct interpolation of GitHub Actions expressions (${{ ... }}) within shell scripts. Instead, values are assigned to environment variables first, then referenced in shell code, preventing potential injection vulnerabilities.
Changes:
- Refactored all workflow files to use environment variables instead of direct expression interpolation
- Applied consistent quoting patterns for shell variable references
- Maintained identical functionality while improving security posture
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/set-version.yaml | Moved package_version and core_major_minor to env vars, updated sed commands and git commit message |
| .github/workflows/pr-modified-files.yml | Moved PR_NUMBER, PR_AUTHOR, and REPO to env vars, updated all gh CLI commands |
| .github/workflows/new-release-branch.yaml | Moved branch_name, package_version, and core_major_minor to env vars, updated sed commands and git operations |
| .github/workflows/lkg.yml | Moved branch_name to env var, updated branch name validation |
| .github/workflows/close-issues.yml | Moved REPO to env var, updated all gh issue commands |
| .github/workflows/ci.yml | Moved matrix.config.bundle and steps.pack.outputs.package to env vars, updated test and smoke test commands |
RyanCavanaugh
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
None of these run with permissions except through manual invocation (and are all validated through the bot anyway), but it's good to not give analyzers the impression that something bad can happen here.