Use forked Adafruit nRF52 framework with LittleFS v1.7.2 and Bluefruit semaphore fix#1922
Open
weebl2000 wants to merge 1 commit intomeshcore-dev:devfrom
Open
Use forked Adafruit nRF52 framework with LittleFS v1.7.2 and Bluefruit semaphore fix#1922weebl2000 wants to merge 1 commit intomeshcore-dev:devfrom
weebl2000 wants to merge 1 commit intomeshcore-dev:devfrom
Conversation
d630837 to
03b94f5
Compare
…t fix Switch from registry package to weebl2000/Adafruit_nRF52_Arduino fork (tag 1.10700.1) which includes: - LittleFS v1.6 → v1.7.2: fixes filesystem corruption on renames - Bluefruit BLE semaphore restore on disconnect: fixes device lockup The build-time patch_bluefruit.py script is no longer needed as the fix is now in the framework source. Co-Authored-By: liquidraver <504870+liquidraver@users.noreply.github.com> Co-Authored-By: taco <taco@sly.nu>
03b94f5 to
b36a301
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch from registry package to weebl2000/Adafruit_nRF52_Arduino fork (tag 1.10700.1) which includes:
The build-time patch_bluefruit.py script is no longer needed as the fix is now in the framework source.
Went ahead and forked, as suggested in PR #1295 - hardcoded platform.io to use the commit id so I can't accidentally update the tag and break things for meshcore.
See upstream repo & tag: https://github.com/weebl2000/Adafruit_nRF52_Arduino/releases/tag/1.10700.1
diff to 1.7.0 weebl2000/Adafruit_nRF52_Arduino@1.7.0...1.10700.1
This PR supersedes #1295, it was already reviewed there. The only thing changed here is we pick in the files from the fork instead of modifying source during the build.