Open
Conversation
Wait 50ms after boot before actually shutting down on low voltage Also fix deadlock issue where only USB can wake the device
Contributor
Author
|
This fixes the problem @Emmpunkt was having - not being able to boot with DC/DC on. |
fschrempf
reviewed
Mar 4, 2026
| if (sd_enabled) { | ||
| sd_power_dcdc_mode_set(NRF_POWER_DCDC_ENABLE); | ||
| } else { | ||
| NRF_POWER->DCDCEN = 1; |
Contributor
There was a problem hiding this comment.
I guess this will increase the power consumption of all NRF52 repeaters (running without softdevice) by something like 20 to 30%.
I have a board with RAK4630 (uart.cz Solar Mesh Baseboard) running with DCDC enabled for several months now without any issues. And a lot of other people are running similar RAK4630 and RAK4631 hardware without such issues.
So I really wonder what is different for @Emmpunkt in #1878 and if this change is justified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only enable DC/DC converter when SoftDevice is managing power.
fixes #1879
Build here https://mcimages.weebl.me/?commitId=fix-rak4631-boot&variant=RAK_4631_repeater