MSC4140: drop delayed state interference tests#845
MSC4140: drop delayed state interference tests#845AndrewFerr wants to merge 1 commit intomatrix-org:mainfrom
Conversation
Don't test that a user's delayed state events are cancelled by a more recent state event from a different user. That behaviour has been delegated to an "alternative" in the delayed event MSC for some time now, and may be removed from Synapse.
There was a problem hiding this comment.
Don't test that a user's delayed state events are cancelled by a more recent state event from a different user. That behaviour has been delegated to an "alternative" in the delayed event MSC4140 for some time now [...]
Can you link the relevant discussion for reference?
There was a problem hiding this comment.
and may be removed from Synapse.
Is this tracked somewhere? Probably best as an issue and link it from a FIXME comment within the code. It would be nice not to forget about when time comes to stabilize this feature.
| }) | ||
| }) | ||
|
|
||
| t.Run("delayed state is not cancelled by new state from the same user", func(t *testing.T) { |
There was a problem hiding this comment.
Don't test that a user's delayed state events are cancelled by a more recent state event from a different user.
This is for the same user. Should we actually remove it as well?
2 participants
Don't test that a user's delayed state events are cancelled by a more recent state event from a different user. That behaviour has been delegated to an "alternative" in the delayed event MSC4140 for some time now, and may be removed from Synapse.
Signed-off-by: Andrew Ferrazzutti andrewf@element.io
Pull Request Checklist